Make wide angle check in wiggle bonus more lenient #31530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Givikap120
changed the title
stanriders
requested changes
Jan 16, 2025
| @@ -102,7 +103,7 @@ public static double EvaluateDifficultyOf(DifficultyHitObject current, bool with | |||
| * DifficultyCalculationUtils.Smootherstep(currAngle, double.DegreesToRadians(110), double.DegreesToRadians(60)) | |||
| * DifficultyCalculationUtils.Smootherstep(osuLastObj.LazyJumpDistance, radius, diameter) | |||
| * Math.Pow(DifficultyCalculationUtils.ReverseLerp(osuLastObj.LazyJumpDistance, diameter * 3, diameter), 1.8) | |||
| * DifficultyCalculationUtils.Smootherstep(lastAngle, double.DegreesToRadians(110), double.DegreesToRadians(60)); | |||
| * DifficultyCalculationUtils.Smootherstep(Math.Min(lastAngle, lastLastAngle), double.DegreesToRadians(110), double.DegreesToRadians(60)); | |||
There was a problem hiding this comment.
That just makes the wiggle bonus potentially completely ignore the second angle no matter if its wide or acute. I don't think it makes any sense to be done like that in a acute wiggle bonus
There was a problem hiding this comment.
this should buff patterns like these without touching anything else
because the main effect of this line is not buffing angle changes on streams, what is still true with this change, because streams have many wide angles in a row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very confusing PR name, but this should be free value boost for alt maps like Bookmaker