Remove use of Loop (and transforms) for slider repeat arrow animations
#31388
+67
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less transforms in gameplay is always better. This fixes repeat arrows animating completely incorrectly in the editor (and probably gameplay when rewinding).
|
Should also close #31316? |
yes, i was searching for this one thanks. |
bdach
requested changes
Jan 6, 2025
peppy
force-pushed
the
fix-reverse-arrow-animation
branch
from
561860a to
8d913e8
Compare
bdach
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less transforms in gameplay is always better. But this also avoids bug ppy/osu-framework#6482.
This fixes repeat arrows animating completely incorrectly in the editor (and probably gameplay when rewinding).
Noticed while reviewing #31354 and had to fix.
Closes #31316
master:
osu.Game.Rulesets.Osu.Tests.2025-01-02.at.09.40.11.mp4
this pr:
osu.Game.Rulesets.Osu.Tests.2025-01-02.at.09.38.22.mp4
i haven't frame comparisoned yet, just rough visual. not sure the previous animations were correct enough to warrant it (might be better to wait for someone to notice an issue).