Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UR estimation to the osu!mania ruleset #22613

Closed
wants to merge 98 commits into from

Merge branch 'master' into maniastatacc

0f47f46
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Add UR estimation to the osu!mania ruleset #22613

Merge branch 'master' into maniastatacc
0f47f46
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, SingleThread) failed May 28, 2024 in 1s

6713 passed, 2 failed and 160 skipped

Tests failed

❌ TestResults-macOS-SingleThread.trx

6875 tests were completed in 2211s with 6713 passed, 2 failed and 160 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.SongSelect.TestScenePlaySongSelect 44✅ 1❌ 1⚪ 41s
osu.Game.Tests.Visual.UserInterface.TestSceneFirstRunSetupOverlay 8✅ 1❌ 21s

❌ osu.Game.Tests.Visual.SongSelect.TestScenePlaySongSelect

✅ TestAudioRemainsCorrectOnRulesetChange(False)
❌ TestAudioRemainsCorrectOnRulesetChange(True)
	"wait for present" timed out
✅ TestAudioResuming
✅ TestAutoplayShortcut
✅ TestAutoplayShortcutKeepsAutoplayIfSelectedAlready
✅ TestAutoplayShortcutReturnsInitialModsOnExit
✅ TestBeatmapOptionsDisabled
✅ TestCarouselSelectionUpdatesOnResume
✅ TestChangeBeatmapAfterEnter
✅ TestChangeBeatmapBeforeEnter
✅ TestChangeBeatmapViaMouseAfterEnter
✅ TestChangeBeatmapViaMouseBeforeEnter
✅ TestChangeBeatmapWhilePresentingScore
✅ TestChangeRulesetWhilePresentingScore
✅ TestChangingRulesetOnMultiRulesetBeatmap
✅ TestConstructor
✅ TestCutInFilterTextBox
✅ TestDeleteHotkey
✅ TestDifficultyIconSelecting
✅ TestDifficultyIconSelectingForDifferentRuleset
✅ TestDummy
✅ TestExternalBeatmapChangeWhileFiltered(False)
✅ TestExternalBeatmapChangeWhileFiltered(True)
✅ TestExternalBeatmapChangeWhileFilteredThenRefilter
✅ TestFilterableModChange
✅ TestFilterOnResumeAfterChange
✅ TestGroupedDifficultyIconSelecting
✅ TestHideSetSelectsCorrectBeatmap
✅ TestImportUnderCurrentRuleset
✅ TestImportUnderDifferentRuleset
✅ TestModOverlayToggling
✅ TestModsRetainedBetweenSongSelect
✅ TestNoFilterOnSimpleResume
✅ TestNonFilterableModChange
✅ TestPlaceholderBeatmapPresence
✅ TestPlaceholderConvertSetting
✅ TestPlaceholderStarDifficulty
✅ TestPresentNewBeatmapNewRuleset
✅ TestPresentNewRulesetNewBeatmap
✅ TestSearchTextWithRulesetCriteria
⚪ TestSelectionRetainedOnBeatmapUpdate
✅ TestSingleFilterOnEnter
✅ TestSorting
✅ TestSpeedChange
✅ TestStartAfterUnMatchingFilterDoesNotStart
✅ TestTextBoxBeatmapDifficultyCount

❌ osu.Game.Tests.Visual.UserInterface.TestSceneFirstRunSetupOverlay

✅ TestBackButton(False)
✅ TestBackButton(True)
✅ TestBasic
✅ TestClickAwayToExit
✅ TestConstructor
✅ TestDoesntOpenOnSecondRun
✅ TestOverlayRunsToFinish(False)
❌ TestOverlayRunsToFinish(True)
	"step through" timed out
✅ TestResumeViaNotification

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Tests.Visual.SongSelect.TestScenePlaySongSelect ► TestAudioRemainsCorrectOnRulesetChange(True)

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  "wait for present" timed out
Raw output
"wait for present" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Tests.Visual.UserInterface.TestSceneFirstRunSetupOverlay ► TestOverlayRunsToFinish(True)

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  "step through" timed out
Raw output
"step through" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)