Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Game Modifiers + Create Mod Stubs #3809

Merged
merged 74 commits into from
Aug 19, 2020

Conversation

MilkyIQ
Copy link
Contributor

@MilkyIQ MilkyIQ commented Jul 2, 2020

Rewrites and Updates the entirety of the "Game Modifiers" article along with the "Summary" article. Resolves #2572. Creates stubs for every single mod listed in the new Game Modifiers article. Resolves part of #3143 and part of #3872.

Images have not been edited or altered. I only removed some redundant ones. Refer to #3943 for progress on image updating.


To-Do:

  • Apply suggestions
  • Finish Score Multiplier stub

This took way too long

@MilkyIQ MilkyIQ marked this pull request as ready for review July 28, 2020 00:30
@MilkyIQ MilkyIQ mentioned this pull request Jul 28, 2020
13 tasks
wiki/Game_modifier/Auto/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Co-op/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Double_Time/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Co-op/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Co-op/en.md Show resolved Hide resolved
wiki/Game_modifier/Relax/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Summary/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Relax/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/ScoreV2/en.md Outdated Show resolved Hide resolved
wiki/Game_modifier/Score_multiplier/en.md Show resolved Hide resolved
MegaApplePi and others added 3 commits August 18, 2020 22:50
Removed FreeMod and NoMod stub as they were less of a stub and more of a definition

Co-Authored-By: Eric <[email protected]>
@MilkyIQ
Copy link
Contributor Author

MilkyIQ commented Aug 19, 2020

a clarification article for No Mod (the absence of a mod) would also be cool as it's a commonly used term within the community. Especially within the tournament scene

Was forced to remove NoMod and FreeMod as they do not have enough depth to be worthy of a stub; their stubs we're ultimately like 3 sentences long. Although it would be cool to some sort of osu! dictionary.

@MilkyIQ MilkyIQ requested a review from MegaApplePi August 19, 2020 18:49
MegaApplePi
MegaApplePi previously approved these changes Aug 19, 2020
@MilkyIQ MilkyIQ closed this Aug 19, 2020
@MilkyIQ MilkyIQ reopened this Aug 19, 2020
…rder

I'm pretty sure that thread ID implies order
@MegaApplePi MegaApplePi merged commit 93fcfee into ppy:master Aug 19, 2020
@MilkyIQ MilkyIQ deleted the rewrite-game-modifiers branch December 2, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Game Modifiers
5 participants