Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overlap stub #3144

Merged
merged 8 commits into from
Feb 3, 2020
Merged

Add Overlap stub #3144

merged 8 commits into from
Feb 3, 2020

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Feb 2, 2020

Still need input on how tags should look

wiki/Mapping_Techniques/Overlap/en.md Outdated Show resolved Hide resolved
@MegaApplePi
Copy link
Contributor

Temporarily blocking for now. I want to see the general game plan and other specifics in #3143 first before jumping the gun on this.

You also mentioned about something needing input on how tags should look. Do you mean that stub: true part?

@Pennek
Copy link
Contributor Author

Pennek commented Feb 2, 2020

no problem for the blocking. these take little effort.

yes the stub. I want that cleared up before pushing these forward, since we dont have a consensus on how to add them for now. god i cant spell

and im unsure how random yaml tags that aren't implemented actually affect the wiki. maybe it would be better to put something in the footer somehow

@cl8n
Copy link
Member

cl8n commented Feb 3, 2020

for now it's probably best to do what Loctav suggested, add a note at the bottom saying this is a stub. I don't think the "stub: true" thing is ever going to turn into a web feature cuz this is starting to get pretty redundant with all of these marker: true tags that have similar effects (see conversation with Venix earlier today)

@cl8n
Copy link
Member

cl8n commented Feb 3, 2020

@MegaApplePi this would be 1. from #3143 (comment) , and even if that were never to be completed i dont think adding these would hurt anything

all that comes to mind for me is that we may need to revisit how indices and Sitemap display this kind of stuff.

@MegaApplePi MegaApplePi removed the state/blocked don't merge label Feb 3, 2020
@MegaApplePi
Copy link
Contributor

Here are some notes on what was discussed through discord regarding the stub mark:

image


For now, we'll mark stubs with an html comment to help identify them in the future. If you think a stub can be further expanded, you could also include the note that clayton wrote at the bottom.

@MegaApplePi MegaApplePi merged commit 3e4e80b into ppy:master Feb 3, 2020
@Loctav Loctav mentioned this pull request Feb 3, 2020
66 tasks
@Pennek Pennek deleted the Overlap branch July 4, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants