Require multiplayer api to join multiplayer room #11743
Merged
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
force-pushed
the
multiplayer-join-room
branch
from
efcf12a to
c67c6ce
Compare
notbakaneko
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
I'm only approving this because web chat doesn't handle rooms with passwords (or maybe prevent rejoining if password set? 🤷 ) @peppy
peppy
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to disallow people from rejoining room after they're kicked and the room password changed. It also makes more sense because it should have same check as joining multiplayer room instead of generic chat room.
The downside is there's currently no way to join multiplayer room through other than client api but apparently we don't really want to support that at the moment? 🤷 @peppy