Automatically create beatmap set description topic on edit if missing #11706
+34
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a solution to the problem of the new beatmap submission server not creating a description topic for the set like the old one did. Notably, this solution implies several shortcuts: - If the main metadata of the set (artist, title) don't change, the forum thread will not be renamed - The forum thread will be posted in a hardcoded forum and never moved, while old BSS would move the thread between forums 6 and 10 depending on whether the beatmap is pending or WIP. Not doing this saves a whole bunch of busy work. - There is no actual body in the forum thread OP, contrary to what old submission did. The aforementioned simplifications were made with the assumption that subforums 6 and 10 on production were going to be hidden away from users due to not containing any actual content that anyone would ever want to see. (Same thing applies to forum 19, which is graveyard.) The *one and only goal* here is that descriptions should be editable for maps submitted using new BSS. Thus I am taking pretty much the same shortcuts that places like the profile page already seem to be.
|
well this is originally my idea, so 🤷 and yay? 👍 and I think it doesn't have to reuse the existing forum...? |
|
Yeah I know you suggested it first. It's moreso that I want as many people as required to agree with this direction. @peppy most of all, probably.
It doesn't, sure. The default is set to something that would work on production immediately. Whether a new forum happens for this can be negotiated as one of the details to work out here. |
|
I have no issue with the direction, FWIW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Please consider this PR as a request for comments / starting point of discussion. It is by no means intended to be 100% complete, and as such I'm opening it as draft until that initial discussion has ran its course and any potential objections have been addressed.
This is a solution to the problem of the new beatmap submission server not creating a description topic for the set like the old one did. Notably, this solution implies several shortcuts:
The aforementioned simplifications were made with the assumption that subforums 6 and 10 on production were going to be hidden away from users due to not containing any actual content that anyone would ever want to see. (Same thing applies to forum 19, which is graveyard - although old threads pre-modding V2 actually do have useful content there. Not sure what to do about that.)
The one and only goal here is that descriptions should be editable for maps submitted using new BSS. Thus I am taking pretty much the same shortcuts that places like the profile page already seem to be.