Merge pull request #9579 from nanaya/score-url

Fix score url
ppy · Dec 2, 2022 · 6ce1af0 · 6ce1af0
2 parents 5e884bc + 90ce078
commit 6ce1af0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/app/Models/Score/Best/Model.php b/app/Models/Score/Best/Model.php
@@ -143,6 +143,11 @@ public function macroForListing()
         };
     }
 
+    public function url(): string
+    {
+        return route('scores.show-legacy', ['mode' => $this->getMode(), 'score' => $this->getKey()]);
+    }
+
     public function userRank($options)
     {
         // laravel model has a $hidden property

diff --git a/app/Models/Score/Model.php b/app/Models/Score/Model.php
@@ -161,11 +161,6 @@ public function getMode(): string
         return snake_case(get_class_basename(static::class));
     }
 
-    public function url()
-    {
-        return route('scores.show', ['mode' => $this->getMode(), 'score' => $this->getKey()]);
-    }
-
     protected function getData()
     {
         $mods = array_map(fn ($m) => ['acronym' => $m, 'settings' => []], $this->enabled_mods);

diff --git a/app/Models/Solo/Score.php b/app/Models/Solo/Score.php
@@ -219,6 +219,11 @@ public function trashed(): bool
         return false;
     }
 
+    public function url(): string
+    {
+        return route('scores.show', $this);
+    }
+
     public function userRank(?array $params = null): int
     {
         return UserRank::getRank(ScoreSearchParams::fromArray(array_merge($params ?? [], [