Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Bonus pp with Change to Make pp Scale Logarithmically #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace Bonus pp with Change to Make pp Scale Logarithmically #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78af3ce
updated score processing code to use new logarithmic sum for pp
Xexxar Sep 13, 2022
852bfc4
updated to latest version of curve
Xexxar Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions osu.Server.Queues.ScoreStatisticsProcessor/Processors/UserTotalPerformanceProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,25 @@ public async Task UpdateUserStatsAsync(UserStats userStats, int rulesetId, MySql
.ToArray();

// Build the diminishing sum
double factor = 1;
double factor = 52.5;
double totalPp = 0;
double totalAccuracy = 0;
double weightTotal = 0;

foreach (var item in groupedItems)
foreach (var (item, i) in groupedItems.Select((value, i) => ( value, i )))
{
totalPp += item.pp!.Value * factor;
totalAccuracy += item.ScoreInfo.Accuracy * factor;
factor *= 0.95;
// This sum is an unbounded logarithmic style summation that uses factor and the index to weight each score.
weight = (1 + Math.Pow(factor / (i + 1), 2)) / (i + 1 + Math.Pow(factor / (i + 1), 2));
totalPp += item.pp!.Value * weight;
totalAccuracy += item.ScoreInfo.Accuracy * weight;
weightTotal += weight;
}

// This weird factor is to keep legacy compatibility with the diminishing bonus of 0.25 by 0.9994 each score.
totalPp += (417.0 - 1.0 / 3.0) * (1.0 - Math.Pow(0.9994, groupedItems.Length));

// We want our accuracy to be normalized.
if (groupedItems.Length > 0)
{
// We want the percentage, not a factor in [0, 1], hence we divide 20 by 100.
totalAccuracy *= 100.0 / (20 * (1 - Math.Pow(0.95, groupedItems.Length)));
// We want the percentage, not a factor in [0, 1], hence 100 in the numerator.
totalAccuracy *= 100.0 / weightTotal;
}

userStats.rank_score = (float)totalPp;
Expand Down