style: use safer and readable code for Path.Join

Turns out this PR broke behaviour between Windows 10 and Windows 11 for some reason. Not tested on other platforms but this is definitely safer than just relying on an error-prone assumption. Co-authored-by: Dean Herbert <[email protected]>
ppy · Jul 6, 2023 · b2c3a5d · b2c3a5d
1 parent fb94b62
commit b2c3a5d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/LocalisationAnalyser.Tools/Program.cs b/LocalisationAnalyser.Tools/Program.cs
@@ -92,8 +92,12 @@ private static async Task projectToResX(FileInfo projectFile, DirectoryInfo? out
                     localisationFile = await LocalisationFile.ReadAsync(stream);
 
                 string targetDirectory = output != null ? output.FullName : Path.GetDirectoryName(file.FilePath)!;
+
                 if (file.Folders.Count > 1)
-                    targetDirectory += string.Join(Path.DirectorySeparatorChar, file.Folders.Skip(1));
+                {
+                    string subNamespaceDirectory = Path.Join(file.Folders.Skip(1).ToArray());
+                    targetDirectory = Path.Join(targetDirectory, subNamespaceDirectory);
+                }
 
                 string targetFileName = localisationFile.Prefix[(localisationFile.Prefix.LastIndexOf('.') + 1)..];
                 string resxFile = Path.Combine(targetDirectory, $"{targetFileName}.resx");