Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "relative mode" by default on platforms which do not handle it well #6469

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Disable "relative mode" by default on platforms which do not handle it well #6469

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fce905
Disable "relative mode" by default on platforms which do not handle i…
frenzibyte Dec 21, 2024
2bbe2d1
Revert "Disable "relative mode" by default on platforms which do not …
frenzibyte Dec 24, 2024
52ed8e7
Disable "relative mode" by default on iOS
frenzibyte Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions osu.Framework.iOS/IOSGameHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using Foundation;
using osu.Framework.Configuration;
using osu.Framework.Extensions;
using osu.Framework.Extensions.ObjectExtensions;
using osu.Framework.Graphics.Textures;
using osu.Framework.Graphics.Video;
using osu.Framework.Input.Bindings;
using osu.Framework.Input.Handlers;
using osu.Framework.Input.Handlers.Mouse;
using osu.Framework.IO.Stores;
using osu.Framework.iOS.Graphics.Textures;
using osu.Framework.iOS.Graphics.Video;
Expand Down Expand Up @@ -83,6 +86,20 @@ public override IResourceStore<TextureUpload> CreateTextureLoaderStore(IResource
public override VideoDecoder CreateVideoDecoder(Stream stream)
=> new IOSVideoDecoder(Renderer, stream);

protected override IEnumerable<InputHandler> CreateAvailableInputHandlers()
{
var handlers = base.CreateAvailableInputHandlers();

foreach (var h in handlers.OfType<MouseHandler>())
{
// Similar to macOS, "relative mode" is also broken on iOS.
h.UseRelativeMode.Value = false;
h.UseRelativeMode.Default = false;
}

return handlers;
}

public override IEnumerable<KeyBinding> PlatformKeyBindings => MacOSGameHost.KeyBindings;
}
}
Loading