Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated indexing response error handler #122

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

notbakaneko
Copy link
Contributor

@notbakaneko notbakaneko commented Aug 8, 2022

Fix some issues found during testing with the response and exception not being handled by the correct case; also sends some error metrics to datadog.

Uses IsValid on response to determine if the request was successful or not. With exceptions, it was messy to figure out which cases should be handled or not. (Other requests like creating indices still use exceptions; in those cases, every error should be considered fatal)

In the event of an error, ServerError may or may not be set depending on what and which stage in the server's processing pipeline an error was triggered. ItemsWithErrors will generally be empty if the processing doesn't get to the index level.

Closed indices will result in either index_closed_exception or cluster_block_exception in the return response items.

Waiting for a server to come back online is removed and waiting for the option to re-queue items without failing them and depleting all the retries. ppy/osu-queue-processor#16

requires

@notbakaneko notbakaneko self-assigned this Aug 8, 2022
@peppy peppy merged commit a0b9a7f into ppy:master Aug 9, 2022
@notbakaneko notbakaneko deleted the feature/updated-error-handler branch August 30, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants