Update hitobject counts in osu_beatmaps table
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already a case of `beatmap.Beatmap.Beatmap` with the existing name, which is nothing short of silly.
smoogipoo
changed the title
osu_beatmapsosu_beatmaps table
peppy
approved these changes
Nov 15, 2024
bdach
reviewed
Nov 15, 2024
| { | ||
| if ((obj.LegacyType & LegacyHitObjectType.Circle) > 0) | ||
| countCircle++; | ||
| if ((obj.LegacyType & LegacyHitObjectType.Slider) > 0) |
There was a problem hiding this comment.
Passing by as I update ppy/osu-server-beatmap-submission#1 to use LegacyHitObjectType too - not sure if it's gonna matter, but BSS included LegacyHitObjectType.Hold in this count too, and I'm about to mirror that. Could prove important for mania maps.
There was a problem hiding this comment.
How... did I miss that D:
bdach
added a commit
to bdach/osu-difficulty-calculator
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereqs:
IHasLegacyHitObjectTypeosu#30578See discussion starting from https://discord.com/channels/188630481301012481/380598781432823815/1304293217533165609
tl;dr: We found this beatmap was listed as having 18 sliders when in reality it has 28. This count is directly read+used by the osu!-ruleset pp processor. Other older beatmaps likely also have incorrect counts.
Of note: Writing
countTotalin particular affects one achievement, but is only used to prevent cheese.osu-web-10writes this value as1 * circles + 2 * sliders + 3 * spinnersfor some reason.