pppd: make pid directory before create the pid file #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulusmack: Have you seen this @DragonBluep PR? |
|
I think I'd prefer it without the #ifdef. |
DragonBluep
force-pushed
the
pid-file
branch
from
d716aa7 to
2fb3a94
Compare
Fixed. Thanks. |
If multilink feature is not enabled, the '/var/run/pppd' directory won't be created before adding pid file. Fixes error message: 'Failed to create pid file /var/run/pppd/pppoe-wan.pid: No such file or directory' Signed-off-by: Shiji Yang <[email protected]>
DragonBluep
force-pushed
the
pid-file
branch
from
2fb3a94 to
a13ff9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.