Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export remote_number into REMOTENUMBER environment variable. #521

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jkroonza
Copy link
Contributor

No description provided.

@jkroonza
Copy link
Contributor Author

@paulusmack would have preferred to keep this handling completely in auth.c but could not find something that's guaranteed to execute between options parsing and net-init execution. Doesn't make sense for our use-case to have this available in net-init ... but I'd prefer to not be short-sighted.

@jkroonza
Copy link
Contributor Author

No code changes, just added Signed-off-by. Works well in production.

@paulusmack paulusmack merged commit d540579 into ppp-project:master Oct 14, 2024
31 checks passed
@jkroonza jkroonza deleted the remotenumberenv branch October 14, 2024 09:33
@Neustradamus Neustradamus removed the request for review from paulusmack October 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants