Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pppd: Add noresolvconf option #512

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

tpaukrt
Copy link
Contributor

@tpaukrt tpaukrt commented Sep 3, 2024

This option allows a user to specify that he does not want to create the /etc/ppp/resolv.conf file with the DNS server addresses.

This option allows a user to specify that he does not want to
create the /etc/ppp/resolv.conf file with the DNS server addresses.

Signed-off-by: Tomas Paukrt <[email protected]>
@paulusmack
Copy link
Collaborator

What is the motivation for this?

Instead of doing this, why not just avoid specifying the usepeerdns option? What's the point of asking the peer for DNS addresses and then not using them?

(This kind of information about the deeper reasons behind what you're doing, and reasons why obvious alternatives weren't chosen, should be in the commit message.)

@tpaukrt
Copy link
Contributor Author

tpaukrt commented Sep 9, 2024

The root filesystem on embedded systems is often read-only, so pppd emits an error message when writing to the resolv.conf file. This new option will prevent that.

DNS servers will still be passed to ip-up/ip-down scripts, where they can be handled much better.

@paulusmack paulusmack merged commit 68ccfb3 into ppp-project:master Sep 10, 2024
31 checks passed
@tpaukrt tpaukrt deleted the noresolvconf branch November 21, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants