Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pppd: Add ip-pre-up-script option #510

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

tpaukrt
Copy link
Contributor

@tpaukrt tpaukrt commented Sep 1, 2024

This option allow a user to specify the path to the script usually located at /etc/ppp/ip-pre-up, similarly to the existing ip-up-script and ip-down-script options.

This option allow a user to specify the path to the script
usually located at /etc/ppp/ip-pre-up, similarly to the
existing ip-up-script and ip-down-script options.

Signed-off-by: Tomas Paukrt <[email protected]>
@paulusmack
Copy link
Collaborator

To the extent that this is just making it possible for the admin to override hard-coded paths as they can for other scripts, this seems OK.

@jkroonza @enaess any comments on this one?

Copy link
Contributor

@jkroonza jkroonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks good.

@paulusmack paulusmack merged commit b918c07 into ppp-project:master Sep 10, 2024
31 checks passed
@tpaukrt tpaukrt deleted the ip-pre-up-script branch November 21, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants