-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calloc calls #416
Fix calloc calls #416
Conversation
These fixes look good. |
@paulusmack: Have you seen this PR? |
@paulusmack: Three month ago, @AtariDreams has done this PR, @enaess is okay, what do you think? |
We should take this, code as is is using the calloc() api wrongly. |
Hmmm... I would take it if the signoff wasn't a noreply.github.com address. Maybe it's trivial enough that that doesn't matter. In any case there is no functional problem here, given that the arguments are multiplied together and multiplication of integers is commutative. |
@AtariDreams: Have you seen the @paulusmack comment? |
@paulusmack: Have you seen the change from @AtariDreams? |
@Neustradamus it's exactly the same change with the same noreply signoff, just rebased. |
@AtariDreams: Can you add the correct sign-off? |
@enaess: Can you look to do like previously? |
@paulusmack: You can not publish the PR directly with a note about @AtariDreams? |
Fixed! |
75c379d
to
2483a7e
Compare
Size and number are switched in calloc sometimes. This PR fixes that. Signed-off-by: Seija Kijin <[email protected]>
Size and number are switched in calloc sometimes. This PR fixes that.