Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockBackend: Implement later-stage witness generation #2168

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

georgwiese
Copy link
Collaborator

Ticks the third item off #2152

This should make the mock prover feature-complete!

@georgwiese georgwiese marked this pull request as ready for review November 28, 2024 08:38
backend/src/mock/mod.rs Outdated Show resolved Hide resolved
backend/src/mock/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Schaeff Schaeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except small form comments. Do we have enough negative tests?

Co-authored-by: Thibaut Schaeffer <[email protected]>
@georgwiese
Copy link
Collaborator Author

Do we have enough negative tests?

No, we have zero!

@Schaeff Schaeff added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit bba060d Nov 29, 2024
14 checks passed
@Schaeff Schaeff deleted the mock-later-stage-witgen branch November 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants