Add option to disable colour #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exussum12
force-pushed
the
optionToDisableColour
branch
from
ddd68d6
to
77601d4
Compare
|
Fixes #140 |
|
@sidz thoughts on bumping Symphony console to 5.3 ? If your not a fan I can re write to have 2 options (--colour and --no colour separately) |
sidz
reviewed
Oct 31, 2021
There was a problem hiding this comment.
IMO we need to support at least 4.4 (LTS). phpmnd doesn't work well with 4.0 and php >= 7.4. But it will be right after we release 2.5. Just would like to merge #145 and we are okay to release 2.5.
Also I'd suggest to not include this feature in 2.5.
Regarding the feature itself:
I'm thinking about removing code highlighter at all and in this case we don't need an additional options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.