-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial push of codegen for Mikrotik RouterOS - routeros-fetch
#770
Open
mobileskyfi
wants to merge
35
commits into
postmanlabs:develop
Choose a base branch
from
tikoci:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,484
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including newman (requires setup) and unit tests.
Any update here? |
…improve first convert speed; added known issues to page
…erator for multiple headers)
potential difference in nodejs version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New codegen for Mikrotik's RouterOS /tool/fetch command, in Postman terms named
routeros-fetch
. The command is used on any Mikrotik router to run web services. But RouterOS syntax is not the easiest since it requires specific escaping. So this "snippet" will deal with mapping a Postman Request, with the right string encoding. Error and tips are presented as RouterOS comments in the snippet. Two new options are addedcommentary
to control if errors/tips are shown &style
to control to specific form of the command as it can be used interactively or as a variable in a larger script.Code was created using "npm boilerplate", with code/structure borrowed from
http
codegen since RouterOS requires similar "raw-like" bodies. Added "test-unit" that verify the RouterOS codegen offline, similar to the http file codegen unit tests.The Newman tests do run successfully, except they require MikroTik RouterOS device running with SSH enabled to test (see codegen/routeros-fetch. I ran these manually.
See Issue #769 - Codegen push for Mikrotik RouterOS's /tool/fetch CLI command (routeros-fetch)