Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inapt demo #20

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

josephmturner
Copy link
Contributor

Resolves #19.

@psionic-k
Copy link
Member

Process nit: needs signoff. The contrib guide should move you right along.

Other than that, LGTM

Signed-off-by: Joseph Turner <[email protected]>
@josephmturner
Copy link
Contributor Author

Process nit: needs signoff.

Done. Thanks!

@psionic-k
Copy link
Member

Sorry I didn't notice, but the commit was also missing GPG signature. Should also be covered in the contrib doc.

@josephmturner
Copy link
Contributor Author

Sorry I didn't notice, but the commit was also missing GPG signature. Should also be covered in the contrib doc.

b455edd should have my signature.

@psionic-k
Copy link
Member

Ah, check https://github.com/positron-solutions/transient-showcase/pull/20/commits

Your email on the commit sig isn't verified yet.

@josephmturner
Copy link
Contributor Author

Your email on the commit sig isn't verified yet.

I have done as you asked, but note that you are asking me to do something which is not explicitly specified in CONTRIBUTING.org. CONTRIBUTING.org tells contributors to sign commits, but it says nothing about adding GPG keys to Github.

If you insist that signatures be "verified" by Github, I suggest that you say so in CONTRIBUTING.org. In addition to the existing link to this help page on signing commits, you might additionally link to this help page on adding GPG keys to Github.

However, I ask that you reconsider making Microsoft the central trust authority for transient-showcase.

@psionic-k
Copy link
Member

However, I ask that you reconsider making Microsoft the central trust authority for transient-showcase.

Pretty funny how that turned out.

There's a longer discussion brewing about trust authorities, but this is a case of using merely sufficient things until better things are available.

@psionic-k psionic-k merged commit 49ad804 into positron-solutions:master Oct 6, 2023
3 checks passed
@josephmturner
Copy link
Contributor Author

@psionic-k sorry for my grumpiness earlier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inapt example
2 participants