Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: QA followup from bs5 shiny theme #639

Merged
merged 4 commits into from
Aug 10, 2023
Merged

bug: QA followup from bs5 shiny theme #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82f654a
Add missing packages for `examples/static_plots/app.py`
schloerke Jul 19, 2023
aa7d93a
Add a spacer in the app to help distinguish the different output
schloerke Jul 19, 2023
ea52b3b
Reorganize button layout
schloerke Jul 19, 2023
df3f1d0
Merge branch 'main' into shiny-theme-followup
schloerke Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/global_pyplot/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
ui.tags.h5("A plot should appear immediately below this text."),
),
ui.output_plot("mpl"),
ui.tags.hr(),
ui.panel_conditional(
"input.render",
ui.tags.h5("An error message should appear immediately below this text."),
Expand Down
1 change: 1 addition & 0 deletions examples/static_plots/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ def holoviews():
@output
@render.plot
def xarray():
# `pooch` module required to download `open_dataset`
import xarray as xr

airtemps = xr.tutorial.open_dataset("air_temperature")
Expand Down
7 changes: 7 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ test =
plotnine
plotly
duckdb
holoviews
bokeh
xarray
geopandas
missingno
pooch

dev =
black>=23.1.0
flake8>=6.0.0
Expand Down
5 changes: 3 additions & 2 deletions shiny/experimental/e2e/sidebar/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
app_ui = ui.page_fixed(
ui.h1("Toggle Sidebars"),
ui.div(
ui.input_action_button("open_all", "Show all", class_="me-1"),
ui.input_action_button("close_all", "Close all", class_="me-2"),
ui.input_action_button("open_all", "Show all", class_="me-1 mb-1"),
ui.input_action_button("close_all", "Close all", class_="mb-1"),
ui.tags.br(),
ui.input_action_button("toggle_outer", "Toggle outer", class_="me-1"),
ui.input_action_button("toggle_inner", "Toggle inner"),
class_="my-2",
Expand Down