bug: QA followup from bs5 shiny theme (#639)

posit-dev · Aug 10, 2023 · 72eb5e4 · 72eb5e4
1 parent da69ea0
commit 72eb5e4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/examples/global_pyplot/app.py b/examples/global_pyplot/app.py
@@ -9,6 +9,7 @@
         ui.tags.h5("A plot should appear immediately below this text."),
     ),
     ui.output_plot("mpl"),
+    ui.tags.hr(),
     ui.panel_conditional(
         "input.render",
         ui.tags.h5("An error message should appear immediately below this text."),

diff --git a/examples/static_plots/app.py b/examples/static_plots/app.py
@@ -118,6 +118,7 @@ def holoviews():
     @output
     @render.plot
     def xarray():
+        # `pooch` module required to download `open_dataset`
         import xarray as xr
 
         airtemps = xr.tutorial.open_dataset("air_temperature")

diff --git a/setup.cfg b/setup.cfg
@@ -72,6 +72,13 @@ test =
     plotnine
     plotly
     duckdb
+    holoviews
+    bokeh
+    xarray
+    geopandas
+    missingno
+    pooch
+
 dev =
     black>=23.1.0
     flake8>=6.0.0

diff --git a/shiny/experimental/e2e/sidebar/app.py b/shiny/experimental/e2e/sidebar/app.py
@@ -7,8 +7,9 @@
 app_ui = ui.page_fixed(
     ui.h1("Toggle Sidebars"),
     ui.div(
-        ui.input_action_button("open_all", "Show all", class_="me-1"),
-        ui.input_action_button("close_all", "Close all", class_="me-2"),
+        ui.input_action_button("open_all", "Show all", class_="me-1 mb-1"),
+        ui.input_action_button("close_all", "Close all", class_="mb-1"),
+        ui.tags.br(),
         ui.input_action_button("toggle_outer", "Toggle outer", class_="me-1"),
         ui.input_action_button("toggle_inner", "Toggle inner"),
         class_="my-2",