Fix issue preventing drag-and-drop files into Explorer view #6030
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
petetronic
approved these changes
Jan 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue that prevents file drag-n-drop from working in the Explorer view.
The problem was that there was no Electron implementation of the accessors that Posit Workbench uses to check for file upload/download permissions. Consequently, in desktop mode these accessors did not work.
The fix is to add accessors to the native (Electron) version of the environment service.
Addresses #5266.
Release Notes
New Features
Bug Fixes
QA Notes
This change doesn't touch the logic for Workbench so testing desktop should be sufficient.