Skip to content

Commit

Permalink
Update: monitoring mixins set to v1.12.0 for pyroscope-mixin (#934)
Browse files Browse the repository at this point in the history
Signed-off-by: Nicolas Lamirault <[email protected]>
Co-authored-by: Nicolas Lamirault <[email protected]>
  • Loading branch information
github-actions[bot] and nlamirault authored Nov 23, 2024
1 parent 591387d commit a41d243
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 107 deletions.
8 changes: 4 additions & 4 deletions charts/pyroscope-mixin/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ keywords:
- kubernetes
- monitoring-mixin
- portefaix
version: 1.4.1
appVersion: 1.2.0
version: 1.5.0
appVersion: 1.10.0
maintainers:
- name: nlamirault
email: [email protected]
Expand All @@ -51,5 +51,5 @@ annotations:
fingerprint: C39918B3EBDE35C23B8D0B8E5F99269A6FCA437C
url: https://keybase.io/nlamirault/pgp_keys.asc
artifacthub.io/changes: |
- kind: fixed
description: ConfigMap dashboards naming
- kind: changed
description: pyroscope-mixin v1.10.0
34 changes: 10 additions & 24 deletions charts/pyroscope-mixin/dashboards/pyroscope-reads.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"keepTime": true,
"tags": [
"pyroscope-mixin",
"monitoring-mixins-v1.5.0"
"monitoring-mixins-v1.12.0"
],
"targetBlank": false,
"title": "Pyroscope Dashboards",
Expand Down Expand Up @@ -71,7 +71,6 @@
{
"expr": "sum by (status) (\n label_replace(label_replace(rate(pyroscope_request_duration_seconds_count{cluster=~\"$cluster\",job=~\"($namespace)/(pyroscope|querier)\", route=~\".*merge.*|.*series.*|.*type.*\"}[$__rate_interval]),\n \"status\", \"${1}xx\", \"status_code\", \"([0-9])..\"),\n \"status\", \"${1}\", \"status_code\", \"([a-zA-Z]+)\"))\n",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{status}}",
"refId": "A"
}
Expand Down Expand Up @@ -146,26 +145,20 @@
{
"expr": "histogram_quantile(0.99, sum by (le,route) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|querier)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ route }} 99th percentile",
"refId": "A",
"step": 10
"refId": "A"
},
{
"expr": "histogram_quantile(0.50, sum by (le,route) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|querier)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ route }} 50th percentile",
"refId": "B",
"step": 10
"refId": "B"
},
{
"expr": "1e3 * sum(job_route_cluster:pyroscope_request_duration_seconds_sum:sum_rate{job=~\"($namespace)/(pyroscope|querier)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"}) by (route) / sum(job_route_cluster:pyroscope_request_duration_seconds_count:sum_rate{job=~\"($namespace)/(pyroscope|querier)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"}) by (route) ",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ route }} Average",
"refId": "C",
"step": 10
"refId": "C"
}
],
"thresholds": [ ],
Expand Down Expand Up @@ -260,7 +253,6 @@
{
"expr": "sum by (status) (\n label_replace(label_replace(rate(pyroscope_request_duration_seconds_count{cluster=~\"$cluster\",job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*merge.*|.*series.*|.*type.*\"}[$__rate_interval]),\n \"status\", \"${1}xx\", \"status_code\", \"([0-9])..\"),\n \"status\", \"${1}\", \"status_code\", \"([a-zA-Z]+)\"))\n",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{status}}",
"refId": "A"
}
Expand Down Expand Up @@ -335,26 +327,20 @@
{
"expr": "histogram_quantile(0.99, sum by (le,route) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ route }} 99th percentile",
"refId": "A",
"step": 10
"refId": "A"
},
{
"expr": "histogram_quantile(0.50, sum by (le,route) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ route }} 50th percentile",
"refId": "B",
"step": 10
"refId": "B"
},
{
"expr": "1e3 * sum(job_route_cluster:pyroscope_request_duration_seconds_sum:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"}) by (route) / sum(job_route_cluster:pyroscope_request_duration_seconds_count:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*merge.*|.*series.*|.*type.*\", cluster=~\"$cluster\"}) by (route) ",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ route }} Average",
"refId": "C",
"step": 10
"refId": "C"
}
],
"thresholds": [ ],
Expand Down Expand Up @@ -406,7 +392,7 @@
"style": "dark",
"tags": [
"pyroscope-mixin",
"monitoring-mixins-v1.5.0"
"monitoring-mixins-v1.12.0"
],
"templating": {
"list": [
Expand All @@ -416,7 +402,7 @@
"value": "default"
},
"hide": 0,
"label": "Data Source",
"label": "Data source",
"name": "datasource",
"options": [ ],
"query": "prometheus",
Expand Down Expand Up @@ -505,4 +491,4 @@
"title": "Pyroscope / Reads",
"uid": "pyroscope-reads",
"version": 0
}
}
60 changes: 16 additions & 44 deletions charts/pyroscope-mixin/dashboards/pyroscope-writes.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"keepTime": true,
"tags": [
"pyroscope-mixin",
"monitoring-mixins-v1.5.0"
"monitoring-mixins-v1.12.0"
],
"targetBlank": false,
"title": "Pyroscope Dashboards",
Expand Down Expand Up @@ -61,26 +61,20 @@
{
"expr": "histogram_quantile(0.99, sum by (le,type) (job_type_cluster:pyroscope_distributor_received_compressed_bytes_bucket:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"})) * 1",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ type }} 99th percentile",
"refId": "A",
"step": 10
"refId": "A"
},
{
"expr": "histogram_quantile(0.50, sum by (le,type) (job_type_cluster:pyroscope_distributor_received_compressed_bytes_bucket:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"})) * 1",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ type }} 50th percentile",
"refId": "B",
"step": 10
"refId": "B"
},
{
"expr": "1 * sum(job_type_cluster:pyroscope_distributor_received_compressed_bytes_sum:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"}) by (type) / sum(job_type_cluster:pyroscope_distributor_received_compressed_bytes_count:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"}) by (type) ",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ type }} Average",
"refId": "C",
"step": 10
"refId": "C"
}
],
"thresholds": [ ],
Expand Down Expand Up @@ -153,26 +147,20 @@
{
"expr": "histogram_quantile(0.99, sum by (le,type) (job_type_cluster:pyroscope_distributor_received_samples_bucket:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"})) * 1",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ type }} 99th percentile",
"refId": "A",
"step": 10
"refId": "A"
},
{
"expr": "histogram_quantile(0.50, sum by (le,type) (job_type_cluster:pyroscope_distributor_received_samples_bucket:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"})) * 1",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ type }} 50th percentile",
"refId": "B",
"step": 10
"refId": "B"
},
{
"expr": "1 * sum(job_type_cluster:pyroscope_distributor_received_samples_sum:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"}) by (type) / sum(job_type_cluster:pyroscope_distributor_received_samples_count:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", type=~\".*\", cluster=~\"$cluster\"}) by (type) ",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{ type }} Average",
"refId": "C",
"step": 10
"refId": "C"
}
],
"thresholds": [ ],
Expand Down Expand Up @@ -267,7 +255,6 @@
{
"expr": "sum by (status) (\n label_replace(label_replace(rate(pyroscope_request_duration_seconds_count{cluster=~\"$cluster\",job=~\"($namespace)/(pyroscope|distributor)\", route=~\".*push.*|.*ingest.*\"}[$__rate_interval]),\n \"status\", \"${1}xx\", \"status_code\", \"([0-9])..\"),\n \"status\", \"${1}\", \"status_code\", \"([a-zA-Z]+)\"))\n",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{status}}",
"refId": "A"
}
Expand Down Expand Up @@ -342,26 +329,20 @@
{
"expr": "histogram_quantile(0.99, sum by (le) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", route=~\".*push.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "99th percentile",
"refId": "A",
"step": 10
"refId": "A"
},
{
"expr": "histogram_quantile(0.50, sum by (le) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", route=~\".*push.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "50th percentile",
"refId": "B",
"step": 10
"refId": "B"
},
{
"expr": "1e3 * sum(job_route_cluster:pyroscope_request_duration_seconds_sum:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", route=~\".*push.*\", cluster=~\"$cluster\"}) / sum(job_route_cluster:pyroscope_request_duration_seconds_count:sum_rate{job=~\"($namespace)/(pyroscope|distributor)\", route=~\".*push.*\", cluster=~\"$cluster\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "Average",
"refId": "C",
"step": 10
"refId": "C"
}
],
"thresholds": [ ],
Expand Down Expand Up @@ -456,7 +437,6 @@
{
"expr": "sum by (status) (\n label_replace(label_replace(rate(pyroscope_request_duration_seconds_count{cluster=~\"$cluster\",job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*push.*|.*ingest.*\"}[$__rate_interval]),\n \"status\", \"${1}xx\", \"status_code\", \"([0-9])..\"),\n \"status\", \"${1}\", \"status_code\", \"([a-zA-Z]+)\"))\n",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{status}}",
"refId": "A"
}
Expand Down Expand Up @@ -531,26 +511,20 @@
{
"expr": "histogram_quantile(0.99, sum by (le) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*push.*|.*ingest.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "99th percentile",
"refId": "A",
"step": 10
"refId": "A"
},
{
"expr": "histogram_quantile(0.50, sum by (le) (job_route_cluster:pyroscope_request_duration_seconds_bucket:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*push.*|.*ingest.*\", cluster=~\"$cluster\"})) * 1e3",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "50th percentile",
"refId": "B",
"step": 10
"refId": "B"
},
{
"expr": "1e3 * sum(job_route_cluster:pyroscope_request_duration_seconds_sum:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*push.*|.*ingest.*\", cluster=~\"$cluster\"}) / sum(job_route_cluster:pyroscope_request_duration_seconds_count:sum_rate{job=~\"($namespace)/(pyroscope|ingester)\", route=~\".*push.*|.*ingest.*\", cluster=~\"$cluster\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "Average",
"refId": "C",
"step": 10
"refId": "C"
}
],
"thresholds": [ ],
Expand Down Expand Up @@ -636,7 +610,6 @@
{
"expr": "sum(pyroscope_head_size_bytes{cluster=~\"$cluster\",job=~\"($namespace)/(pyroscope|ingester)\",}) by (type)",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{type}}",
"legendLink": null
}
Expand Down Expand Up @@ -712,7 +685,6 @@
{
"expr": "sum(pyroscope_head_size_bytes{cluster=~\"$cluster\",job=~\"($namespace)/(pyroscope|ingester)\",}) by (instance)",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{instance}}",
"legendLink": null
}
Expand Down Expand Up @@ -766,7 +738,7 @@
"style": "dark",
"tags": [
"pyroscope-mixin",
"monitoring-mixins-v1.5.0"
"monitoring-mixins-v1.12.0"
],
"templating": {
"list": [
Expand All @@ -776,7 +748,7 @@
"value": "default"
},
"hide": 0,
"label": "Data Source",
"label": "Data source",
"name": "datasource",
"options": [ ],
"query": "prometheus",
Expand Down Expand Up @@ -865,4 +837,4 @@
"title": "Pyroscope / Writes",
"uid": "pyroscope-writes",
"version": 0
}
}
21 changes: 4 additions & 17 deletions charts/pyroscope-mixin/templates/configmap-dashboards.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,3 @@
# Copyright (C) Nicolas Lamirault <[email protected]>
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# SPDX-License-Identifier: Apache-2.0

{{ if .Values.grafanaDashboard.enabled -}}
{{- $files := .Files.Glob "dashboards/*.json" }}
{{- if $files }}
Expand All @@ -22,15 +6,17 @@ apiVersion: v1
kind: ConfigMapList
items:
{{- range $path, $fileContents := $files }}
{{- $dashboardName := regexReplaceAll "(^.*/)(.*)\\.json$" $path "${2}" }}
{{- $dashboardName := regexReplaceAll "(^.*/)(.*)\\.json$" $path "${2}" | lower }}
- apiVersion: v1
kind: ConfigMap
metadata:
annotations:
grafana-folder: {{ $.Values.grafanaDashboard.folder }}
{{- include "pyroscope-mixin.annotations" $ | indent 6 }}
labels:
grafana-dashboard: {{ $dashboardName }}
{{- include "pyroscope-mixin.labels" $ | indent 6 }}
app.kubernetes.io/component: dashboard
name: {{ printf "dashboard-%s" $dashboardName | trunc 63 | trimSuffix "-" }}
namespace: {{ include "pyroscope-mixin.namespace" $ }}
data:
Expand All @@ -46,6 +32,7 @@ kind: GrafanaDashboard
metadata:
labels:
{{- include "pyroscope-mixin.labels" $ | indent 4 }}
app.kubernetes.io/component: dashboard
name: {{ printf "%s" $dashboardName | trunc 63 | trimSuffix "-" | lower }}
namespace: {{ $.Release.Namespace }}
spec:
Expand Down
Loading

0 comments on commit a41d243

Please sign in to comment.