Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical time applet #670

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coolGi69
Copy link

@coolGi69 coolGi69 commented Sep 26, 2024

This PR contains 2 fixes to the vertical time applet.

  1. Fixed seconds not showing on the time applet when the setting is enabled in the settings
  2. Made reading the date more pleasing in the vertical layout. This just makes both the month & day use numbers and take up 2 digits.
    This also fixes Japanese time format overflowing due to it previously splitting based on a whitespace (which doesn't exist in the Japanese locale)
    The table below shows this change.
Old Look New Look
old new

Japanese Time Format Causing Overflow:
image

@wiiznokes
Copy link
Contributor

I think your code can cause problem for the ordering of the date. In France its day/month/year (like it should 😄). Icu handle it. In the future, we could use slitToPart for that ( unicode-org/icu4x#4936 (comment)). For now, i would suggest to find a way to split it for Japanese (it possible ?)

@coolGi69
Copy link
Author

coolGi69 commented Sep 26, 2024

It's now top-to-bottom on the size of the dates, which should probs stay the same in every locale (I'm an Australian who also uses day/month/year, so maybe I'm biased in this...). So the month (09) at the top, then day (26) below it, and the rest of the date below that (hour then minute). Should that be done?

I could change it to properly format Japanese dates (looks like 9月26日 and use year/month/day) and have that split (becoming 9月 and 26日), but the 月 & 日 kanji don't really have much significance due to just being a break to indicate the number prior being the month-of-the-year or day-of-the-month.
Also, the look of having the short month name (Sept) looks a tad jarring, hence why it's probs better to keep it as the number (09).

@coolGi69
Copy link
Author

coolGi69 commented Oct 3, 2024

Would it be better if I split the patch for the seconds in the vertical format into a different PR, or is it fine to keep it in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants