Systematic testing enhancements #4161
Conversation
ponylang-main
added
the
discuss during sync
| " Use a specific seed value for systematic testing.\n" \ | ||
| " --ponysystematictestingverbosity\n" \ | ||
| " Control verbosity of systematic testing output.\n" \ | ||
| " 0 is least verbose; greater is more details.\n" \ |
There was a problem hiding this comment.
It would be nice to mention here what the highest meaningful value this could be is.
Is it 3? 5? 9? 99? 999?
There was a problem hiding this comment.
Right now the max value used is 10 (for no particular reason) but i haven't figured out how the levels of details should work and how far they should go (any ideas?). i expect that the levels of detail is something that will eventually get well defined and stabilized over time.
There was a problem hiding this comment.
I don't have opinions about how high the levels of verbosity should go - whatever you have now (e.g. 10) is probably fine.
I just think that this documentation string should mention that maximum number so that I (as a user seeing this documentation string) don't need to search through the whole codebase to find out what the highest meaningful number is.
dipinhora
force-pushed
the
systematicenhancements
branch
from
44c3b22 to
c237129
Compare
|
rebased to fix merge conflicts |
ponylang-main
added
the
discuss during sync
Update SYSTEMATIC_TESTING_PRINTF to take a level argument. Add cli argument for controlling output level of systematic testing printf's. Add SYSTEMATIC_TESTING_YIELD and SYSTEMATIC_TESTING_PRINTF in a lot more places.
dipinhora
force-pushed
the
systematicenhancements
branch
from
c237129 to
7f9a122
Compare
|
rebased to fix merge conflicts |
|
Once @jemc's comment about max value is addressed, I'm ok with these changes especially given that this is a new feature that I haven't used and I trust that @dipinhora is doing the right thing. |
SeanTAllen
removed
the
discuss during sync
|
@dipinhora interested in finishing this off? |
ponylang-main
added
the
discuss during sync
it's on my list.. but it can't be in this version of things.. need to account for things like the scheduler mutex (and/or get it working without pthreads) and the cycle detector critical which i didn't properly account for in this PR.. |
|
@dipinhora can i close this then? |
|
doh! yes.. closing.. |
ponylang-main
added
discuss during sync
Update SYSTEMATIC_TESTING_PRINTF to take a level argument.
Add cli argument for controlling output level of systematic testing printf's.
Add SYSTEMATIC_TESTING_YIELD and SYSTEMATIC_TESTING_PRINTF in a lot more places.