-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: FFI Tuples #4157
Draft
jemc
wants to merge
22
commits into
main
Choose a base branch
from
ffi-tuples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: FFI Tuples #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
Should be discussed during an upcoming sync
label
Jul 7, 2022
jemc
force-pushed
the
ffi-tuples
branch
5 times, most recently
from
July 7, 2022 19:28
c4f7a43
to
7ceaddd
Compare
The extens the _assert_infinite() function in packages/collections/_test.pony to detect bugs in infinite Ranges
This removes the checks that were introduced in PR #2012 that only allow intrinsic FFI calls to use tuples. Now, tuples can again be passed into and returned from FFI functions (with all previously identified limitations).
remove unused variables
Add FFI tuple compile tests to libponyc test suite
This reverts commit 3378759.
SeanTAllen
removed
the
discuss during sync
Should be discussed during an upcoming sync
label
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress branch, but I'm only opening as a draft PR here so that I can begin testing all platforms via our CI jobs.
Don't bother reviewing the code right now or paying any attention to this at this time.