Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client3:async-http-client-backend-cats, ... to 3.3.1 #72

Conversation

scala-steward
Copy link
Contributor

Updates

from 3.2.3 to 3.3.1.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

labels: library-update, semver-minor

@majk-p
Copy link
Member

majk-p commented May 10, 2021

This requires CE3 (https://github.com/softwaremill/sttp/releases/tag/v3.3.0), while sttp-oauth2 currently only works with CE2 until #64 is merged.

We should consider migrating to "com.softwaremill.sttp.client3" %% "async-http-client-backend-cats-ce2" or even providing builds for both CE version.

@kubukoz
Copy link
Member

kubukoz commented May 10, 2021

To provide builds for both versions, I think it's best to maintain two branches - this approach has proven to be effective for other libraries. But as long as Ocado doesn't need CE3 support, let's keep only CE2 on main :)

@kubukoz kubukoz closed this May 10, 2021
@scala-steward
Copy link
Contributor Author

Superseded by #74.

@scala-steward scala-steward deleted the update/async-http-client-backend-cats-3.3.1 branch May 13, 2021 12:48
@kubukoz
Copy link
Member

kubukoz commented May 13, 2021

bro, it was already closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants