Initial attempt at 3.0.0 support #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
May 14, 2021
| @@ -34,7 +33,8 @@ object common { | |||
| object Scope { | |||
| def of(rawScope: String): Option[Scope] = refineV[ValidScope](rawScope).toOption | |||
|
|
|||
| def refine: RefineMPartiallyApplied[Refined, ValidScope] = refineMV[ValidScope] | |||
| // todo - refined doesn't provide macros for 3.x yet | |||
There was a problem hiding this comment.
I have an idea for a smol macro of our own for 3.x...
kubukoz
commented
May 14, 2021
build.sbt
Outdated
| "org.scalatest" %% "scalatest" % Versions.scalaTest, | ||
| "io.circe" %% "circe-literal" % Versions.circe | ||
| "org.scalatest" %% "scalatest" % Versions.scalaTest | ||
| // todo - circe-literal isn't built for 3.x yest |
kubukoz
changed the title
|
well, this depends on #64 now (sttp hasn't released for 3.0.0 final before the CE3 migration) |
|
Will be implemented in #172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things are still missing, but in general I'd say this will be an easy migration.
Tests will fail because circe-literal is currently removed.