Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom token response in AuthorizationCodeGrant #104

Merged
merged 8 commits into from
Jun 19, 2021
Merged

Custom token response in AuthorizationCodeGrant #104

merged 8 commits into from
Jun 19, 2021

Conversation

majk-p
Copy link
Member

@majk-p majk-p commented Jun 16, 2021

No description provided.

@majk-p majk-p marked this pull request as draft June 16, 2021 21:08
@majk-p majk-p requested a review from tplaskowski June 17, 2021 09:32
@majk-p majk-p changed the title Custom token response Custom token response in AuthorizationCodeGrant Jun 17, 2021
tplaskowski
tplaskowski approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@tplaskowski tplaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are rather minor 🙂

oauth2/src/main/scala/com/ocadotechnology/sttp/oauth2/AuthorizationCode.scala Outdated Show resolved Hide resolved
oauth2/src/main/scala/com/ocadotechnology/sttp/oauth2/AuthorizationCodeProvider.scala Outdated Show resolved Hide resolved
oauth2/src/main/scala/com/ocadotechnology/sttp/oauth2/Oauth2TokenResponse.scala Outdated Show resolved Hide resolved
oauth2/src/test/scala/com/ocadotechnology/sttp/oauth2/AuthorizationCodeSpec.scala Outdated Show resolved Hide resolved
majk-p added 2 commits June 19, 2021 12:47
@majk-p
Copy link
Member Author

majk-p commented Jun 19, 2021

Guess this partially addresses #11

@majk-p majk-p marked this pull request as ready for review June 19, 2021 10:58
@majk-p majk-p added the breaking Source or binary breaking change label Jun 19, 2021
@majk-p
Copy link
Member Author

majk-p commented Jun 19, 2021

Accepting this MR with broken pipeline, as it's only a failed MiMa check. It will be fixed automatically when tagged as v0.10.0.

@majk-p majk-p merged commit 569698f into main Jun 19, 2021
@majk-p majk-p mentioned this pull request Jul 14, 2021
Closed
@sbrunk sbrunk mentioned this pull request Jul 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tplaskowski tplaskowski tplaskowski approved these changes

@kubukoz kubukoz kubukoz approved these changes

Assignees
No one assigned
Labels
breaking Source or binary breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majk-p @kubukoz @tplaskowski