Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass extra include directory needed for jsoncpp on OpenBSD #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass extra include directory needed for jsoncpp on OpenBSD #8

wants to merge 1 commit into from

Conversation

jasperla
Copy link

No description provided.

@patrick96
Copy link
Member

Isn't that something that should be provided by pkg-config from the jsoncpp.pc file?

@jasperla
Copy link
Author

Turns out that the include directory from the jsoncpp.pc file was not actually included. I've now amended patch.

patrick96
patrick96 requested changes Nov 22, 2019
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to directly use the JSONCPP_INCLUDE_DIRS name instead of JSONCPP_INCLUDEDIR. This way we don't have to manually set the JSONCPP_INCLUDEDIR variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick96 patrick96 patrick96 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasperla @patrick96