This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
Fixed module_id string value of CodeStored event #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cloned and deployed polkascan-os locally to harvest blocks from a substrate-based blockchain network with pallet-contracts enabled. It turns out that deployed contracts are not harvested into polkascan.data_contract table.
I traced the issue, and found out that the module id of CodeStoredEventProcessor is misspelled. Thus, CodeStoredEventProcessor is not retrieved from ProcessorRegistry and invoked within PolkascanHarvesterService.add_block method.
This pull request corrects the module_id string value of contract CodeStored event.