Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix empty output of to_arrow() on filtered unit height DataFrame #20656

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jan 10, 2025

Fixes #20627

Fix Column::n_chunks()/rechunk() to account for the chunks in the cached materialized Series for the scalar case, which can be created if ScalarColumn::from_single_value_series() is called with a Series with >1 chunks.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 10, 2025
@nameexhaustion nameexhaustion changed the title fix: Fix empty output of to_arrow() on unit height filtered DataFrame fix: Fix empty output of to_arrow() on filtered unit height DataFrame Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (8abd261) to head (5bde175).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/column/mod.rs 52.38% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20656   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files        1557     1557           
  Lines      220696   220714   +18     
  Branches     2517     2517           
=======================================
+ Hits       174297   174312   +15     
- Misses      45825    45828    +3     
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d5b6719 into pola-rs:main Jan 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars.DataFrame.to_arrow drops resulting data when using shift within filter
2 participants