fix: Properly load nested Parquet Statistics #20610
Merged
+434
−1,695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
coastalwhite
changed the title
github-actions
bot
added
fix
coastalwhite
force-pushed
the
fix/parquet-nested-statistics-20510
branch
from
5907888 to
56a3263
Compare
coastalwhite
commented
Jan 8, 2025
There was a problem hiding this comment.
All these files are now just merged into statistics.rs
coastalwhite
commented
Jan 8, 2025
| @@ -19,24 +19,12 @@ fn round_trip_opt_stats( | |||
| compression: CompressionOptions, | |||
| encodings: Vec<Encoding>, | |||
| ) -> PolarsResult<()> { | |||
| let (array, _statistics) = match file { | |||
There was a problem hiding this comment.
The statistics were ignored here anyway, so I just removed them.
This fixes a bug where nested statistics were incorrectly being loaded as if they were proper values. Fixes pola-rs#20510.
coastalwhite
force-pushed
the
fix/parquet-nested-statistics-20510
branch
from
56a3263 to
f0118a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20610 +/- ##
==========================================
+ Coverage 79.00% 79.04% +0.04%
==========================================
Files 1566 1557 -9
Lines 221034 220498 -536
Branches 2510 2510
==========================================
- Hits 174618 174292 -326
+ Misses 45842 45632 -210
Partials 574 574 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where nested statistics were incorrectly being loaded as if they were proper values.
Fixes #20510.