Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support writing partitioned parquet to cloud #20590

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: Support writing partitioned parquet to cloud #20590

merged 1 commit into from
Jan 8, 2025

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #20502

@nameexhaustion nameexhaustion added the breaking rust Change that breaks backwards compatibility for the Rust crate label Jan 7, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (785bb1e) to head (c69a8b5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/partition.rs 66.66% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20590      +/-   ##
==========================================
- Coverage   79.00%   79.00%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      221034   221029       -5     
  Branches     2510     2510              
==========================================
- Hits       174623   174613      -10     
- Misses      45837    45842       +5     
  Partials      574      574

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion force-pushed the write-parquet-partitioned-cloud branch from 73676df to c69a8b5 Compare January 8, 2025 07:35
@nameexhaustion nameexhaustion marked this pull request as ready for review January 8, 2025 08:29
@ritchie46 ritchie46 merged commit bd4dd65 into pola-rs:main Jan 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using write_parquet with partition_by breaks writing to S3
2 participants
@nameexhaustion @ritchie46