Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Reduce size of ArrowDataType by boxing heavy variants #20588

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 7, 2025

This reduces the size of ArrowDataType from 64 to 32 bytes.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 39.68254% with 76 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (04004b8) to head (df9f62a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/ffi/schema.rs 67.56% 12 Missing ⚠️
crates/polars-arrow/src/io/ipc/write/schema.rs 38.88% 11 Missing ⚠️
crates/polars-arrow/src/io/ipc/read/schema.rs 0.00% 9 Missing ⚠️
crates/polars-arrow/src/io/ipc/write/mod.rs 11.11% 8 Missing ⚠️
crates/polars-arrow/src/io/ipc/read/common.rs 14.28% 6 Missing ⚠️
crates/polars-parquet/src/arrow/write/schema.rs 0.00% 6 Missing ⚠️
crates/polars-arrow/src/datatypes/mod.rs 37.50% 5 Missing ⚠️
crates/polars-arrow/src/io/avro/read/schema.rs 0.00% 5 Missing ⚠️
crates/polars-row/src/encode.rs 0.00% 4 Missing ⚠️
crates/polars-core/src/series/from.rs 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20588      +/-   ##
==========================================
- Coverage   78.97%   78.95%   -0.02%     
==========================================
  Files        1564     1564              
  Lines      220807   220863      +56     
  Branches     2510     2510              
==========================================
+ Hits       174377   174389      +12     
- Misses      45855    45899      +44     
  Partials      575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 2490555 into pola-rs:main Jan 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants