Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python): Make parameter of str.to_decimal keyword-only #20570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

depr(python): Make parameter of str.to_decimal keyword-only #20570

wants to merge 1 commit into from
+4 −1

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jan 6, 2025

Close #20564

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Jan 6, 2025
@eitsupi eitsupi mentioned this pull request Jan 6, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (e0ef7f9) to head (62f2d68).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20570      +/-   ##
==========================================
- Coverage   78.98%   78.97%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220738   220740       +2     
  Branches     2504     2504              
==========================================
- Hits       174350   174339      -11     
- Misses      45814    45828      +14     
+ Partials      574      573       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python: Shouldn't Expr.str.to_decimal's argument be keyword-only?
2 participants
@eitsupi @stinodego