Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement list.min and list.max for list[i128] #20488

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

lukemanley
Copy link
Contributor

Also adds i128 to SIGNED_INTEGER_DTYPES which adds i128 to a number of numeric tests including test_list_min_max which this PR addresses.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 28, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (f43a7d4) to head (b43c765).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20488   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files        1563     1563           
  Lines      220596   220601    +5     
  Branches     2492     2492           
=======================================
+ Hits       174317   174334   +17     
+ Misses      45706    45694   -12     
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Nice one. Thanks a lot!

@ritchie46 ritchie46 merged commit 5671b0f into pola-rs:main Dec 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants