Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python)!: Remove pyxlsb engine from read_excel #16784

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 6, 2024

Ref #13525

This engine has been superseded by calamine. I'd gather get rid of the optional dependency now.

@alexander-beedie Any objections?

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 6, 2024
@alexander-beedie
Copy link
Collaborator

@alexander-beedie Any objections?

None at all ;)

@stinodego stinodego marked this pull request as ready for review June 6, 2024 14:28
@stinodego stinodego merged commit 3a36067 into main Jun 6, 2024
16 of 18 checks passed
@stinodego stinodego deleted the break-readdb branch June 6, 2024 14:36
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 17, 2024
@stinodego stinodego changed the title feat(python)!: Remove pyxlsb engine from read_database feat(python)!: Remove pyxlsb engine from read_excel Jul 3, 2024
@github-actions github-actions bot added the breaking Change that breaks backwards compatibility label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants