Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): properly set boolean distinct count #16782

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(rust): properly set boolean distinct count #16782

merged 2 commits into from
Jun 6, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #16765

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Jun 6, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #16782 will degrade performances by 15.06%

Comparing coastalwhite:fix-boolean-distinct (25a2265) with main (b329894)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main coastalwhite:fix-boolean-distinct Change
⚡ test_filter1 762.8 µs 653.9 µs +16.66%
❌ test_groupby_h2oai_q1 2.4 ms 2.8 ms -15.06%

@henrikig henrikig mentioned this pull request Jun 6, 2024
Closed
@ritchie46 ritchie46 merged commit 1fbfa08 into pola-rs:main Jun 6, 2024
21 of 22 checks passed
@coastalwhite coastalwhite deleted the fix-boolean-distinct branch June 6, 2024 15:53
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coastalwhite @ritchie46 @c-peters