-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Added List dtype support with all subtypes for from_repr
functionality
#16226
Open
tharunsuresh-code
wants to merge
18
commits into
pola-rs:main
Choose a base branch
from
tharunsuresh-code:nested_dtypes_repr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(python): Added List dtype support with all subtypes for from_repr
functionality
#16226
tharunsuresh-code
wants to merge
18
commits into
pola-rs:main
from
tharunsuresh-code:nested_dtypes_repr
+258
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
labels
May 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16226 +/- ##
==========================================
- Coverage 81.44% 81.43% -0.01%
==========================================
Files 1409 1409
Lines 184725 184763 +38
Branches 2971 2984 +13
==========================================
+ Hits 150442 150457 +15
- Misses 33763 33783 +20
- Partials 520 523 +3 ☔ View full report in Codecov by Sentry. |
tharunsuresh-code
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
May 17, 2024 23:15
tharunsuresh-code
changed the title
feat(python): Added List dtype support with Integer and Float subtypes for
feat(python): Added List dtype support with all subtypes for May 18, 2024
from_repr
functionalityfrom_repr
functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for recognizing List dtype for column data when using
from_repr
functionality #15842Reused code blocks from INTEGER_DTYPES and FLOAT_DTYPES to use for casting List subtypes.