-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust!): Move CSV read options from CsvReader
to CsvReadOptions
#16126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
commented
May 9, 2024
nameexhaustion
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
May 9, 2024 05:25
ritchie46
reviewed
May 9, 2024
nameexhaustion
commented
May 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16126 +/- ##
==========================================
- Coverage 80.96% 80.95% -0.01%
==========================================
Files 1386 1386
Lines 178437 178492 +55
Branches 2882 2882
==========================================
+ Hits 144463 144496 +33
- Misses 33480 33502 +22
Partials 494 494 ☔ View full report in Codecov by Sentry. |
nameexhaustion
changed the title
[wip] Refactor CSV options
refactor(rust!): Move CSV read options from May 10, 2024
CsvReader
to CsvReadOptions
github-actions
bot
added
breaking rust
Change that breaks backwards compatibility for the Rust crate
internal
An internal refactor or improvement
rust
Related to Rust Polars
labels
May 10, 2024
Nice one @nameexhaustion! Great cleanup. 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking rust
Change that breaks backwards compatibility for the Rust crate
internal
An internal refactor or improvement
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring to move CSV read options from the CsvReader out to the options struct. This will make it easier to create multiple readers from the same set of options for the new CSV file list reading implementation.
This PR should not change any read behavior, only the way in which a CsvReader is constructed.
Todos after this:
LossyUtf8
(2 places)Outdated
This is currently in a state where it builds for Python, and the layout of the options struct is pretty much what I aimed for it to be. What's left is just updating tests / docs on the rust side, but it's will be better to wait until after we review the new layout (as there are a lot of them).