[Code Health] Ensure tokenomics module msg responses are non-empty #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
on-chain
Olshansk
approved these changes
Dec 2, 2024
red-0ne
approved these changes
Dec 6, 2024
* pokt/main: (22 commits) [Docs] How do I access my CometBFT endpoint externally? (#986) [Docs] Full Node Documentation Update (#941 followup) (#981) Comment ou tthe sed check [Application] Support filtering apps by delegatee gateway address (#957) [Docs] Add PATH gateway cheat sheet (#964) [Docs] Fix Docker Walkthrough gateway container name and add supplier staking note (#939) [Bug, Testing] fix: app transfer module-integration test (#980) [Tokenomics] refactor: `GlobalInflationPerClaim` var usage to param usage (#953) feat: add global_inflation_per_claim param to tokenomics module (#951) [Bug, Tooling] fix: app/gateway/supplier stake/unstake make targets (#978) [Supplier] refactor: `SupplierStakingFee` var usage to param usage (#948) chore: add localnet_config option to disable hot-reloading (#979) [Code Health] fix: tokenomics module gRPC return errors (#963) [Code Health] fix: supplier module gRPC return errors (#962) [Supplier] feat: add `staking_fee` param to supplier module (#944) [Code Health] fix: application module gRPC status error returns (#954) [Code Health] fix: shared module gRPC return errors (#961) [Code Health] fix: session module gRPC status return errors (#960) [Code Health] fix: service module gRPC status error returns (#959) [Code Health] fix: proof module gRPC status error returns (#956) ...
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure all supplier module msg responses are non-empty. This adds a
Paramsfield to the following protobuf type(s), and updates the unit tests to assert for presence and correctness.MsgUpdateParamsResponseIssue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist