Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add global_inflation_per_claim param to tokenomics module #951

Merged
merged 23 commits into from
Dec 2, 2024
Merged

feat: add global_inflation_per_claim param to tokenomics module #951

merged 23 commits into from
Dec 2, 2024

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Add global_inflation_per_claim param to the tokenomics module.

Issue

  • TODO_BETA

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added governance Governance related changes on-chain On-chain business logic devnet-test-e2e tokenomics Token Economics - what else do you need? consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Nov 21, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 951)
Grafana network dashboard for devnet-issue-951

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 21, 2024
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 21, 2024 21:43
@bryanchriswhite bryanchriswhite mentioned this pull request Nov 21, 2024
Merged
15 tasks
bryanchriswhite and others added 6 commits November 27, 2024 16:13
@bryanchriswhite
[Service] refactor: TargetNumRelays var usage to param usage (#943)
9ae1129 
## Summary

Replace usage of `servicekeeper.TargetNumRelays` with the new param and
delete it.

## Issue

- `TODO_BETA`

## Type of change

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [x] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [ ] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [x] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [ ] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable
@bryanchriswhite @red-0ne
chore: review feedback improvements
256d001 
Co-authored-by: red-0ne <[email protected]>
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into todo_beta/params/target…
35121d6 
…_num_relays

* pokt/main:
  [Docs/Tools] Validator: support multiple networks + cheat sheet (#941)
  [Docs] Upgrade list (#928)
  [Docs] Beta TestNet - Service Cheatsheet (#965)
  Commit outdated proto files
  [Docs] adding params - fix gRPC status error code (#958)
  [Docs] Update links to RPC & explorers (#950)
  [Docs] Update documentation on installing the `poktrolld` CLI (#949)
@bryanchriswhite @red-0ne
chore: review feedback improvements
9efa98c 
Co-authored-by: red-0ne <[email protected]>
@bryanchriswhite
Merge branch 'todo_beta/params/target_num_relays' into todo_beta/para…
d84d799 
…ms/supplier_staking_fee
@bryanchriswhite
Merge branch 'main' into todo_beta/params/supplier_staking_fee
6f3f514
@github-actions github-actions bot removed the devnet label Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 951)
Grafana network dashboard for devnet-issue-951

@github-actions github-actions bot added the devnet label Dec 2, 2024
@bryanchriswhite
Merge branch 'todo_beta/params/supplier_staking_fee' into todo_beta/r…
0d6f2fb 
…efactor/supplier_staking_fee
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into todo_beta/refactor/supp…
9d1c26f 
…lier_staking_fee

* pokt/main:
  chore: add localnet_config option to disable hot-reloading (#979)
  [Code Health] fix: tokenomics module gRPC return errors (#963)
  [Code Health] fix: supplier module gRPC return errors (#962)
  [Supplier] feat: add `staking_fee` param to supplier module (#944)
  [Code Health] fix: application module gRPC status error returns (#954)
  [Code Health] fix: shared module gRPC return errors (#961)
  [Code Health] fix: session module gRPC status return errors (#960)
  [Code Health] fix: service module gRPC status error returns (#959)
  [Code Health] fix: proof module gRPC status error returns (#956)
  [Code Health] fix: gateway module gRPC status error returns (#955)
@bryanchriswhite
Merge branch 'todo_beta/refactor/supplier_staking_fee' into todo_beta…
89d0554 
…/params/global_inflation_per_claim

* todo_beta/refactor/supplier_staking_fee: (21 commits)
  chore: add localnet_config option to disable hot-reloading (#979)
  [Code Health] fix: tokenomics module gRPC return errors (#963)
  [Code Health] fix: supplier module gRPC return errors (#962)
  [Supplier] feat: add `staking_fee` param to supplier module (#944)
  [Code Health] fix: application module gRPC status error returns (#954)
  [Code Health] fix: shared module gRPC return errors (#961)
  [Code Health] fix: session module gRPC status return errors (#960)
  [Code Health] fix: service module gRPC status error returns (#959)
  [Code Health] fix: proof module gRPC status error returns (#956)
  [Code Health] fix: gateway module gRPC status error returns (#955)
  [Tokenomics] feat: add `target_num_relays` param to service module (#930)
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs/Tools] Validator: support multiple networks + cheat sheet (#941)
  [Docs] Upgrade list (#928)
  [Service] refactor: `TargetNumRelays` var usage to param usage (#943)
  [Docs] Beta TestNet - Service Cheatsheet (#965)
  Commit outdated proto files
  [Docs] adding params - fix gRPC status error code (#958)
  [Docs] Update links to RPC & explorers (#950)
  ...
@bryanchriswhite bryanchriswhite changed the base branch from todo_beta/refactor/supplier_staking_fee to main December 2, 2024 13:50
@bryanchriswhite bryanchriswhite merged commit 88c5321 into main Dec 2, 2024
11 checks passed
@bryanchriswhite bryanchriswhite changed the title feat: add global_inflation_per_claim param to tokenomics module feat: add global_inflation_per_claim param to tokenomics module Dec 2, 2024
@bryanchriswhite bryanchriswhite deleted the todo_beta/params/global_inflation_per_claim branch December 2, 2024 14:20
bryanchriswhite added a commit that referenced this pull request Dec 9, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/663/fix/tokenomics
cb913f6 
* pokt/main: (22 commits)
  [Docs] How do I access my CometBFT endpoint externally? (#986)
  [Docs] Full Node Documentation Update (#941 followup) (#981)
  Comment ou tthe sed check
  [Application] Support filtering apps by delegatee gateway address (#957)
  [Docs] Add PATH gateway cheat sheet (#964)
  [Docs] Fix Docker Walkthrough gateway container name and add supplier staking note (#939)
  [Bug, Testing] fix: app transfer module-integration test (#980)
  [Tokenomics] refactor: `GlobalInflationPerClaim` var usage to param usage (#953)
  feat: add global_inflation_per_claim param to tokenomics module (#951)
  [Bug, Tooling] fix: app/gateway/supplier stake/unstake make targets (#978)
  [Supplier] refactor: `SupplierStakingFee` var usage to param usage (#948)
  chore: add localnet_config option to disable hot-reloading (#979)
  [Code Health] fix: tokenomics module gRPC return errors (#963)
  [Code Health] fix: supplier module gRPC return errors (#962)
  [Supplier] feat: add `staking_fee` param to supplier module (#944)
  [Code Health] fix: application module gRPC status error returns (#954)
  [Code Health] fix: shared module gRPC return errors (#961)
  [Code Health] fix: session module gRPC status return errors (#960)
  [Code Health] fix: service module gRPC status error returns (#959)
  [Code Health] fix: proof module gRPC status error returns (#956)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

Assignees

@bryanchriswhite bryanchriswhite

Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e governance Governance related changes on-chain On-chain business logic push-image CI related - pushes images to ghcr.io tokenomics Token Economics - what else do you need?
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @red-0ne