[On-Chain] Claim/Proof on-chain events #629
Conversation
bryanchriswhite
added
on-chain
|
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 629) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bryanchriswhite
force-pushed
the
issues/580/events/refactor+feat
branch
from
dfe9c1f to
3de0683
Compare
bryanchriswhite
force-pushed
the
issues/580/events/refactor+feat
branch
from
3de0683 to
7f8b902
Compare
bryanchriswhite
force-pushed
the
issues/580/events/refactor+feat
branch
from
0131b17 to
d48e73e
Compare
…tor+feat * pokt/main: [Relayminer] off-chain claim/proof message distribution (#619)
| message MsgSubmitProofResponse { | ||
| poktroll.proof.Proof proof = 1; |
There was a problem hiding this comment.
👍
We should consider revisiting our Msg keepers to return whatever they created/updated
| telemetry.ClaimComputeUnitsCounter( | ||
| types.ClaimProofStage_CLAIMED, | ||
| numComputeUnits, | ||
| err, |
There was a problem hiding this comment.
Shouldn't we meter numRelays too?
There was a problem hiding this comment.
This is a telemetry call, not an event emission. This particular telemetry call is specific to compute units.
There was a problem hiding this comment.
I'm realizing that I misunderstood your message initially but I get it now. I'm not sure what the state of the code was at the time but now it looks like this:
telemetry.ClaimCounter(types.ClaimProofStage_CLAIMED, 1, err)
telemetry.ClaimComputeUnitsCounter(
types.ClaimProofStage_CLAIMED,
numComputeUnits,
err,
)There was a problem hiding this comment.
Nope. Did it again. 😅🙈
I've opened #643 to track this.
| event, err := cosmostypes.ParseTypedEvent(abci.Event(events[0])) | ||
| require.NoError(t, err) | ||
|
|
||
| claimCreatedEvent, ok := event.(*types.EventClaimCreated) |
| return &types.MsgSubmitProofResponse{}, nil | ||
| numRelays, err = claim.GetNumRelays() | ||
| if err != nil { | ||
| return nil, status.Error(codes.Internal, types.ErrProofInvalidClaimRootHash.Wrap(err.Error()).Error()) |
There was a problem hiding this comment.
Did you intend to reuse these errors?
There was a problem hiding this comment.
Yes, I believe this error is accurate. If claim.GetNumRelays() or claim.GetNumComputeUnits() fails, it's because the root is invalid.
|
|
||
| option go_package = "github.com/pokt-network/poktroll/x/proof/types"; | ||
|
|
||
| enum ClaimProofStage { |
| message MsgSubmitProofResponse { | ||
| poktroll.proof.Proof proof = 1; |
| @@ -297,3 +250,71 @@ func (s *suite) waitForNewBlockEvent( | |||
| s.Log("Success; message detected before timeout.") | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These helpers LGTM. Did you take some time to make sure we reuse them elsewhere? (i.e. some of the work I did that should leverage them)
There was a problem hiding this comment.
Yessir! 🫡 My observation was that the spaghetti code was strewn between the session, relay, and settlement scenarios.
Co-authored-by: Redouane Lakrache <[email protected]>
Summary
num_relaysand renamecompute_unitstonum_compute_units.Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist