Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration Review - DO NOT MERGE] Session module #386

Closed
wants to merge 23 commits into from

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Feb 15, 2024

Summary

Human Summary

Review branch for the Session module migration to rollkit/cosmos-sdk v0.50.x (see: migration notion doc).

Once this branch is approved, review and merge #382

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify): Module migration to rollkit/cosmos-sdk v0.50.x

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@red-0ne red-0ne added session Changes related to Session management code health Cleans up some code labels Feb 15, 2024
@red-0ne red-0ne added this to the Shannon TestNet milestone Feb 15, 2024
@red-0ne red-0ne self-assigned this Feb 15, 2024
@red-0ne red-0ne mentioned this pull request Feb 15, 2024
11 tasks
@red-0ne red-0ne marked this pull request as ready for review February 15, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code session Changes related to Session management
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants