Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] Application module #378

Closed
wants to merge 14 commits into from
Closed

[Migration] Application module #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a6c7474
scaffold: module application --dep bank,account,gateway
red-0ne Feb 10, 2024
060dcfa
scaffold: map application --module application
red-0ne Feb 10, 2024
a19887d
scaffold: message stake-application --module application
red-0ne Feb 10, 2024
28d4ddf
scaffold: message unstake-application --module application
red-0ne Feb 10, 2024
7f5c7ab
scaffold: message delegate-to-gateway --module application
red-0ne Feb 10, 2024
004773a
scaffold: message undelegate-from-gateway --module application
red-0ne Feb 10, 2024
c9e3caf
reconcile: application.proto
red-0ne Feb 10, 2024
54dbb7e
reconcile: fix MsgStakeApplication types
red-0ne Feb 11, 2024
d6f5287
reconcile: application module files
red-0ne Feb 11, 2024
d67ff4f
reconcile: Address review change requests
red-0ne Feb 14, 2024
7255e42
reconcile: Fix wrong error message
red-0ne Feb 14, 2024
1140daf
reconcile: Fix proto signre filed name
red-0ne Feb 14, 2024
e8b6be4
fix: msg/autocli arguments mismatch
red-0ne Feb 15, 2024
5e4966a
chore: application module review improvements
bryanchriswhite Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,5 @@ jobs:
reporter: github-check
level: warning
locale: "US"

# TODO_IMPROVE: Enforce using k.Logger() when logging in the `x/` directory code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the cosmos-sdk logger is not ideal because its debug level is not really useful; the default level is info and the debug log contains a bunch of cosmos-sdk specific output which obscures our application's debug logs. I think we may be better served by using polylog on-chain, for example.

Suggested change
# TODO_IMPROVE: Enforce using k.Logger() when logging in the `x/` directory code.
# TODO_IMPROVE: Consider whether to enforce using a particular logger when logging in the `x/` directory code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change and discussion should probably be moved to the migration/base review.

2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ itest: check_go_version ## Run tests iteratively (see usage for more)
.PHONY: go_mockgen
go_mockgen: ## Use `mockgen` to generate mocks used for testing purposes of all the modules.
find . -name "*_mock.go" | xargs --no-run-if-empty rm
# go generate ./x/application/types/
go generate ./x/application/types/
go generate ./x/gateway/types/
# go generate ./x/supplier/types/
# go generate ./x/session/types/
Expand Down
Loading
Loading