Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2E tests - RPC URL path #1008

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: E2E tests - RPC URL path #1008

merged 1 commit into from
Dec 13, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 13, 2024

Summary

Update the E2E step definition which queries the gateway. The path was /v1, and is now /v1/ to avoid a redirect response.

Issue

E2E tests involving relays fail on main.

Previously, POSTing to the /v1 path returned a response directly; it now seems to redirect to /v1/ which curl can't reliably handle on all platforms.

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

(cherry picked from commit 3b40880)
@bryanchriswhite bryanchriswhite added testing Test (or test utils) additions, fixes, improvements or other devnet-test-e2e labels Dec 13, 2024
@bryanchriswhite bryanchriswhite self-assigned this Dec 13, 2024
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1008)
Grafana network dashboard for devnet-issue-1008

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Dec 13, 2024
@bryanchriswhite bryanchriswhite marked this pull request as ready for review December 13, 2024 13:55
@bryanchriswhite bryanchriswhite merged commit 8ea6c15 into main Dec 13, 2024
12 checks passed
@bryanchriswhite bryanchriswhite deleted the fix/e2e/path-path branch December 13, 2024 14:00
bryanchriswhite added a commit that referenced this pull request Dec 13, 2024
* pokt/main:
  [Relayminer, Bug] fix: sessiontree logger never initialized (#993)
  fix: E2E tests - RPC URL path (#1008)
  Updated cheat sheat docs with an example after installation (#1004)
  fix: Nil session tree logger (#1007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io testing Test (or test utils) additions, fixes, improvements or other
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants